urwid / urwid / 37015511991

91%

push

github

Reject non-finite Pile sizes, fix weight overflow (#1385)

Pile accepted inf, NaN and over-large int sizes, and render then
crashed converting a row share to int. Huge finite weights crashed the
same way, and at a fixed size weights too far apart crashed pack(())
and render(()) with OverflowError.

- Contents validation rejects sizes that are not finite or do not fit
  in a float.
- Box rendering scales weights to at most 1 when rows * sum could
  overflow a float.
- _get_fixed_rows_sizes raises PileError instead of OverflowError
  when the weight ratio scales a height past the float range.
- The public methods that accept size () document the PileError they
  raise when the children cannot be sized as a fixed widget.

4581 of 5512 branches covered (83.11%)

Branch coverage included in aggregate %.

8 of 8 new or added lines in 1 file covered. (100.0%)

11516 of 13143 relevant lines covered (87.62%)

9.79 hits per line