urwid / urwid / 37014927690

91%

push

github

Reject non-finite Columns widths and weights (#1384)

A width or weight of inf or nan, or weights whose sum overflowed a
float, passed validation and crashed rendering with ValueError or
OverflowError. At a fixed size, weights too far apart crashed pack(())
and render(()) the same way.

- Contents validation rejects widths and weights that are not finite
  or do not fit in a float.
- column_widths scales the weights down when their share computation
  could overflow a float, and keeps minimum widths when all weights
  are zero instead of dividing by a zero total.
- _get_fixed_column_sizes raises ColumnsError instead of OverflowError
  when the weight ratio scales a width past the float range.
- The public methods that accept size () document the ColumnsError
  they raise when the children cannot be sized as a fixed widget, and
  move_cursor_to_coords documents the ValueError it raises instead.

4579 of 5510 branches covered (83.1%)

Branch coverage included in aggregate %.

10 of 10 new or added lines in 1 file covered. (100.0%)

11511 of 13138 relevant lines covered (87.62%)

9.79 hits per line