romshark / datapages / 37002637828

41%

Build Type

push

github

Committed by romshark

Commit Message

fix: Keep streams of mixed pages open when hidden

Write openWhenHidden for a page with both public and user-addressed
events when its GET returns enableBackgroundStreaming set to true.
Without it, the page drops its reload on visibility, but its stream
still closes with the tab, and the events published while the tab is
hidden never reach the page. Take this page:

    // PageRoom is /room
    type PageRoom struct{ App *App }

    func (PageRoom) GET(r *http.Request) (
        body datapages.Component,
        bg datapages.EnableBackgroundStreaming,
        err error,
    ) {
        return roomPage(), true, nil
    }

    // Public: EventPosted has no SubjectUser field.
    func (PageRoom) OnPosted(e EventPosted, sse datapages.SSE) error

    // Private: EventNoticed has a SubjectUser field.
    func (PageRoom) OnNoticed(e EventNoticed, sse datapages.SSE) error

It renders these streams for a signed-in visitor and a guest,
neither with openWhenHidden:true:

    data-init="@get('/room/_$/',{retry:'always',...})"
    data-init="@get('/room/_$/anon/',{retry:'always',...})"

Only a page with both kinds of events is affected.

Coverage Stats

15 of 23 new or added lines in 1 file covered. (65.22%)

14 existing lines in 1 file now uncovered.

14654 of 36220 relevant lines covered (40.46%)

544.92 hits per line