romshark / datapages / 37001032554

44%

Build Type

push

github

Committed by romshark

Commit Message

fix: Keep embedded actions that share a suffix

Compare a page's actions with those of its embedded types by full
method name, the way Go resolves promoted methods. A comparison by
suffix drops Saver.PUTSave from PageItem, which declares POSTSave:

    type Saver struct{ App *App }

    // PUTSave is /item/save
    func (Saver) PUTSave(r *http.Request) error

    // PageItem is /item
    type PageItem struct {
        App *App
        Saver
    }

    // POSTSave is /item/save
    func (PageItem) POSTSave(r *http.Request) error

datapages gen writes no PUT route and no action builder for PUTSave,
and the server answers a PUT to /item/save with 405. The same happens
when Saver declares both actions.

Coverage Stats

4 of 7 new or added lines in 1 file covered. (57.14%)

2 existing lines in 1 file now uncovered.

14668 of 36229 relevant lines covered (40.49%)

544.75 hits per line