Eyevinn / mp4ff / 36999015018

83%

push

github

fix(mp4)!: make leva grouping_type a four-character string

LevaLevel.GroupingType was a uint32, while SbgpBox.GroupingType and SgpdBox.GroupingType hold the same grouping_type field (ISO/IEC 14496-12 8.8.13, 8.9.2, 8.9.3) as a string. Info() printed it with %d, so a level assigned by the seig grouping showed as groupingType=1936025959.

GroupingType and the groupingType argument of NewLevaLevel are now strings, read and written as four bytes like in sbgp and sgpd, and Info() prints the code. NewLevaLevel and EncodeSW reject a grouping type that is not four bytes for assignment types 0 and 1, since Size() counts four bytes for it and a different length would corrupt the box.

BREAKING CHANGE: LevaLevel.GroupingType and the groupingType argument of NewLevaLevel change from uint32 to string.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

12 of 12 new or added lines in 1 file covered. (100.0%)

22968 of 27841 relevant lines covered (82.5%)

0.83 hits per line