penguinolog / urwid / 36973696105

86%

Build Type

push

github

Committed by web-flow

Commit Message

Fix watch_pipe double close, end-of-file spin and async reads (#1380)

- With an async callback the pipe stayed readable until the task read it,
  so a second task was started whose read raised BlockingIOError and
  ended the loop; such a task now returns.
- A callback returning False closed the read end but left the entry, so
  remove_watch_pipe() closed the descriptor again, possibly another
  file's; remove_watch_pipe() is now the only place that closes it, and a
  callback acts only while its own watch is registered.
- At end of file the pipe stayed readable and the loop spun at full CPU;
  the callback now gets b"" once and the watch is removed.
- watch_pipe() drops an entry left under a reused write-end number.

Coverage Stats

4554 of 5486 branches covered (83.01%)

Branch coverage included in aggregate %.

18 of 20 new or added lines in 1 file covered. (90.0%)

152 existing lines in 4 files now uncovered.

11439 of 13067 relevant lines covered (87.54%)

9.77 hits per line