penguinolog / urwid / 36869562409

86%

Build Type

push

github

Committed by web-flow

Commit Message

Fix input parser crashes on crafted terminal input (#1368)

Terminal input such as a paste could raise out of process_keyqueue and end
the main loop:

- A run of about 1000 ESC bytes exhausted the recursion limit; the first of
  three ESCs in a row is now decoded on its own.
- Text after "ESC [ <" that is not "Pb;Px;Py" plus M/m raised ValueError and
  was buffered without bound; it now decodes as ordinary keys, and a report
  body is capped at _SGR_MOUSE_MAX_LEN codes.
- ESC followed by a terminal report (DECRPM reply) raised AttributeError; the
  ESC is now kept as a separate key, which also drops the urwid.util import.

Coverage Stats

4521 of 5474 branches covered (82.59%)

Branch coverage included in aggregate %.

14 of 14 new or added lines in 1 file covered. (100.0%)

1137 existing lines in 54 files now uncovered.

11343 of 13023 relevant lines covered (87.1%)

9.74 hits per line