umputun / agterm / 36916055754

94%

Build Type

push

github

Committed by web-flow

Commit Message

feat(remote): default ssh keepalive for remote panes unless the user's config sets one (#683)

* feat(remote): default ssh keepalive for remote panes unless the user's config sets one

Without keepalive a dropped link stays a frozen pane until the TCP timeout, minutes later. The wrapper
asks ssh -G for the effective ServerAliveInterval and passes 5/2 only when it is 0, so a value set in
ssh_config still wins; a command-line -o would override it.

Claude-Session: https://claude.ai/code/session_01GiNNp4Fiq8JFqMxqz3N9x6

* fix(remote): the keepalive check runs with the attach's own arguments; tests tell four words from one

Review notes on #683. ssh -G without the remote command never enters a Match command or Match sessiontype
block, so a keepalive set there read as 0 and the added options overrode it; the check now carries the
attach's own arguments. The fake ssh logged "$*", which could not tell the four option words from one
quoted word or an empty host, so it records one argument per line like the zmx fake and the tests compare
argv elements. The docs say the default applies only when the pane's ssh owns its connection (not under
ControlMaster), that ssh drops on the third missed check, so within about 15 s, and that an explicit
ServerAliveInterval 0 also gets the default.

Claude-Session: https://claude.ai/code/session_01GqkEnpmSQ9B16JabFfNGjx

---------

Co-authored-by: Ivan Kuznetsov <kuzma@Ivans-MacBook-Pro.local>

Coverage Stats

10 of 10 new or added lines in 1 file covered. (100.0%)

48 existing lines in 2 files now uncovered.

14568 of 15548 relevant lines covered (93.7%)

2624639.76 hits per line