microlinkhq / browserless / 36892244751

81%

push

github

refactor(function): drop ownsContext and the preserveContext it fed (#955)

Audited every option against its consumers. `ownsContext` has none: no
caller in any package passes it, so it was always `true`, which made
`preserveContext: !ownsContext` permanently false and the branch it
guards in `packages/browserless` unreachable.

It was added in #948 for a handover design that ended up using `getPage`
instead, and never removed. `preserveContext` goes with it rather than
staying as an option nothing can reach.

`keepPage` stays: the API's page retainer uses it.

The README documented passing your own context through `getBrowserless`,
which was only safe alongside `ownsContext: false`. Without that flag the
run always destroys the context, so following it would close the caller's
pages. The section is gone rather than left as advice that no longer
holds.

The three screenshot pixel-diff failures in `packages/browserless` fail
identically with these changes stashed.

Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>

436 of 520 branches covered (83.85%)

Branch coverage included in aggregate %.

7 of 7 new or added lines in 1 file covered. (100.0%)

1565 of 1854 relevant lines covered (84.41%)

23.71 hits per line