FAIRmat-NFDI / nomad-simulations / 36885092487

87%

push

github

Restrict `contributions` to `HamiltonianTerm`; separate out `relativity` (#501)

Add `HamiltonianTerm` as the base for additive Hamiltonian terms and retype
`ModelMethod.contributions` to it, so a full method can no longer nest inside
its own `contributions` — removing the recursive self-nesting artifact that
`.@` mapping-parser annotations produced. Rebase the term classes
(`ImplicitSolvationModel`, `EmpiricalDispersionModel`, `SelfInteractionCorrection`,
`HubbardInteractions`, `NonlocalCorrelation`, and force-field `Potential`) onto
`HamiltonianTerm`.

`RelativityModel` stays as the typed `ModelMethodElectronic.relativity`
subsection — it transforms the Hamiltonian rather than adding a separable term.
`numerical_settings` remains on `BaseModelMethod` so methods and terms alike
keep their own.

Closes #324.

42 of 42 new or added lines in 4 files covered. (100.0%)

10404 of 11909 relevant lines covered (87.36%)

4.37 hits per line