FAIRmat-NFDI / nomad-simulations

86%

LAST BUILD ON BRANCH develop

branch: SELECT

CHANGE BRANCH

x

Sync Branches

• No branch selected
• 240-disambiguate-crystal-symmetry-symbols-port
• add-bsdft
• add-generic-mass
• add-legend
• add-semi-empirical-methods
• add-sic
• add-workflow-docs
• archive_data_update
• auto-generate-docs
• basis-set-canonicalization
• bulky-to-hdf5
• change-pp-atomsstate-ref-direction
• check-atom-particles
• determinant-fix
• develop
• dft-type
• distinguish-modelmethod-numerical-settings
• extend_forcefield_parameters_v2
• feature/selfconsistency-flexible-units
• fix-archive_to_universe
• fix-basis-set-container
• fix-deploy-action
• fix-ee-mo
• fix-kmesh-high-symmetry-ase-lattice-mismatch
• fix-kmesh-use-ase-get-special-points
• fix-kmesh-use-seekpath
• fix-multiref-inheritance
• fix-non-conv-lattices
• fix-orbital-localization
• fix-particle-cgbeadstate
• fix-workflow
• fix/issue-126-kmesh-normalization-order
• hdf5-datasets-for-bulky-numerics
• integrate-atom-parameters
• libxc-consistency
• local-coupled-cluster
• metadata-extractor
• migrate-tutorial
• mo-cube
• multiref-archive-labels
• multireference-qc
• nao
• nonlocal-correlation
• norm-migration
• norm-migration-patch
• oniom-methods
• orb-volume
• post-transfer-hygiene
• prune_long_trajectory
• rdf
• refactor-explanation-docs
• refactor-explanation-docs-p186-integration
• remove-temp-tests
• rename-qc-methods-for-consistency
• rename-semi-empirical
• replace_getattr_with_direct_access
• rm-eln-annotations
• test-geometry-optimization-edge-cases
• tighten-atomsstate-definition
• typed-physical-constraints
• v0.6.0
• v0.7.0
• warnings_and_errors
• warnings_and_errors-JFR

Build # 29045851850

Build Type

push

github

Committed by web-flow

Commit Message

Fix high-symmetry k-point normalization crashes via SeeKpath (#403, closes #401)

`KMesh.high_symmetry_points` resolution relied on ASE's Bravais-lattice objects, whose attributes did not always match NOMAD's stored Pearson/Bravais label; the uncaught `AttributeError`s surfaced as "could not normalize section" failures on non-conventional lattices. The PR began as a defensive fallback around those mismatches, but since the root cause is ASE classifying the cell from its geometry alone, it resolves the problem by replacing that path entirely.

High-symmetry points are now derived from the full crystal structure (lattice and atomic positions) via SeeKpath/HPKOT, using the same `symmetry_tolerance` as MatID, so the k-points and the stored `bravais_lattice` agree by construction; coordinates are expressed in the input cell's reciprocal basis, and resolution degrades to a warning instead of crashing.

Adds the `seekpath`/`spglib` dependencies, regression tests, and primitive-cell reference fixtures.

Co-authored-by: Nathan Daelman <ndaelman@physik.hu-berlin.de>

Coverage Stats

108 of 115 new or added lines in 4 files covered. (93.91%)

9864 of 11457 relevant lines covered (86.1%)

2.58 hits per line