decentraland / builder / 36876318520

57%

master: 57%

Pull #3512

github

fix: describe a rollback that actually restores the target

The previous wording said a rollback is two dispatches, the abandoned version
to 0% and the target to 100%. That holds only when exactly one record sits
above the target. Records are sorted descending by semver and the worker serves
the first whose percentage covers the user, so every version above the target
has to be zeroed -- after a few pushes that is several commit builds.

It also had the order backwards. Zeroing first leaves a window where whatever
record sits below the target serves instead, and these dispatches share a
concurrency group per environment, so a third queued behind a running one
cancels the second while it is pending -- deploying nothing and reporting no
failure, which is the shape this workflow exists to avoid. Restoring the target
first and zeroing downward never opens that window.

It also dropped the note about versions published before this workflow existed.
Those prefixes carry no `.deploy-complete.json`, and the broker refuses to point
at an upload it cannot confirm finished, so they need the older manual path.

2636 of 5727 branches covered (46.03%)

Branch coverage included in aggregate %.

7629 of 12288 relevant lines covered (62.08%)

37.21 hits per line