decentraland / builder / 36767830502

57%

push

github

feat: deploy through the cdn-deploy action instead of the npm relay (#3511)

* feat: deploy through the cdn-deploy action instead of the npm relay

Deploying went through four hops: oddish published the built `dist/` to npm,
that triggered a GitLab pipeline, the pipeline uploaded the tarball to the CDN
bucket, and a `deployment_status` webhook fired `set-rollout` to write the
Cloudflare KV record. Every hop needed a credential in this repository --
`GITLAB_CDN_DEPLOYER_TOKEN`, `GITLAB_CDN_DEPLOYER_URL`, `NPM_TOKEN` -- and a
failure in the middle left the site on the previous version with a green run.

`cdn-deploy` does the whole thing in one step: it settles the version, runs the
build, uploads to S3 and writes the rollout through a broker that authenticates
this repository by GitHub OIDC. No Cloudflare token and no IAM role live here
any more; the broker checks `decentraland/definitions` to confirm this
repository owns `@dcl/builder-site` before it will write anything.

Behaviour is preserved, not changed. A push to master still rolls out to zone
and today at 100%, which is what the two steps in `set-rollout` did. The build
keeps the same `CI` and `NODE_PATH` it had, at job level now because the build
runs inside a composite action and those do not inherit step `env:`.

The npm publish goes with it. `@dcl/builder-site` on npm existed to move bytes
to the CDN, which S3 now receives directly.

`set-rollout-manual.yaml` stays: it can set a version to 0%, which the new
`promote` job cannot express, and that is what a real rollback needs.

* fix: give each deploy path its own concurrency group

One group for the whole workflow meant a release and a push could never run at
the same time, and GitHub keeps only one pending run per group: a release
waiting behind a push deploy was cancelled outright when the next push landed.
A cancelled run deploys nothing and reports no failure, which is the failure
this migration is most prone to.

Serialising them here wa... (continued)

2636 of 5727 branches covered (46.03%)

Branch coverage included in aggregate %.

7629 of 12288 relevant lines covered (62.08%)

37.21 hits per line