Qiskit / qiskit / 36858156643

88%

Build Type

push

github

Committed by web-flow

Commit Message

Expose the pass manager to C  (#16839)

* Basic implementation

A basic initial implementation of a pass, task and passmanager. Has a first test to show the execution model works, but has no worked out pass context and no callback infrastructure yet.

* add callback registry

* Add tests for callback and io_types

* More tests & clippy

* Low hanging fruit from first reviews

* Rm unnecessary submodule

* PassContext as execution handle

* Implement a global PassManagerContext

* Fix clippy warnings

* Rework callbacks as traits

This makes callbacks extensible in the future w/o breaking ABI compat for C

* clippy

* Allow deleting keys

* More ergonomics

- More default types
- Fix passing dyn Any into the callbacks
- Implement Debug for Task/PM

* Remove insert/remove

* Revert `value as _`

* Fix dev-dependencies

* Remove callback handling

We need to redesign how the callbacks will run in the future.  As
written, this changes the structure of the `PassManager::run` method,
but even if we expose that in this same release, we can still add a
`PassManager::run_with_callbacks` in the future, so we're not tying our
hands.

The problem with the current state was that we hadn't fully designed how
to handle callbacks at different execution points; the system for a
single callback at the end of an atomic task execution mostly worked,
but we hadn't fully designed what information about the pass and the
state should be given.  This extended to the callback methods that were
intended to be called at "structure" points (like after a task list).

* Fix tests with `cache_pygates`

`DAGCircuit::push_operation_back` has a conditional Python-gate object
in its argument list.  It's easier just to build the `CircuitData`.

* Simplify push-task interfaces

* Make `Debug` implementation idiomatic

Using the `Formatter` methods properly lets us integrate with the
linebreak infrastructure, and so on.

This also motivates adding a `Pass::name` method for human-readable
o... (continued)

Coverage Stats

238 of 259 new or added lines in 6 files covered. (91.89%)

23 existing lines in 3 files now uncovered.

122731 of 139274 relevant lines covered (88.12%)

939280.89 hits per line