Qiskit / qiskit / 36882281753

88%

Build Type

push

github

Committed by web-flow

Commit Message

Add Delay with units of `Dt` to the C API (#16915)

* Initia: Expand ability of using delay in a Circuit
- The following commit enables users to:
    - Add a Delay instruction of `Dt` units in a circuit.
    - Retreive the duration of a `Delay` instruction in the circuit.
    - Retrieve the duration value as a parameter from a `QkCircuitInstruction`.

* Fix: Add `qk_param_kind` and `qk_param_as_int` to tests.

* Docs: Add release note.

* Rename: `qk_circuit_delay_get_unit` to `qk_circuit_delay_unit`

* Fix: Adapt to latest changes.

* Fix: Use `i64` as input for duration.
- Add failure condition via exit code.
- Add test.

* Apply batched suggestions from code review

Co-authored-by: Julien Gacon <gaconju@gmail.com>

* Fix: Documentation
- Re-emphazise that we return an error if the duration is negative.
- Add Safety section to `qk_circuit_delay_inner`.

* Fix: typo

* Docs: Add UB docstring for `qk_circuit_delay_unit`

* Docs: Address index out of range

* Add: Unknown and Expr variants to CDelayUnit.
- Add a test to see if this is working well.
- Remove panic condition from `qk_circuit_delay_unit`.

* Fix: Use get_unchecked for circuit instruction fetching.

* Apply batched suggestions from code review

Co-authored-by: David F. Cohen <me@davidfcohen.com>

* Fix: Warn about incorrect delay units
- Update documentation to specify that `DelayUnit_DT` and `DelayUnit_EXPR`. are incompatible.
- Return exitcode when `QKDelayUnit` is invalid in `qk_circuit_delay`.

---------

Co-authored-by: Julien Gacon <gaconju@gmail.com>
Co-authored-by: David F. Cohen <me@davidfcohen.com>

Coverage Stats

44 of 54 new or added lines in 2 files covered. (81.48%)

5 existing lines in 2 files now uncovered.

122804 of 139335 relevant lines covered (88.14%)

938784.9 hits per line