ruby-grape / grape / 36849486132

100%

master: 100%

push

github

Raise from error! instead of throwing :error

error! threw :error, and a throw is not an exception. Active Record
commits a transaction that a throw leaves, so error! inside a
transaction saved what the block had written while the client was told
the request failed. A throw cannot leave the fiber it was thrown in
either, so error! inside an Async task answered 500.

error! now raises Grape::Exceptions::Halt, a StandardError carrying the
same ErrorResponse. The error middleware takes it inside its catch, so
it is rendered where a thrown error is and never reaches rescue_from.
Its backtrace is preset empty, as Validation's is, so raise skips
capturing one.

throw :error from middleware and rescue_from handlers keeps working.

Fixes #2197

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

1512 of 1513 branches covered (99.93%)

Branch coverage included in aggregate %.

14 of 14 new or added lines in 3 files covered. (100.0%)

4399 of 4400 relevant lines covered (99.98%)

29574.59 hits per line