pmd / pmd / 842

80%

push

github

[java] ExceptionAsFlowControl: a throw in a lambda invoked by the method it is passed to (#7118)

* [java] ExceptionAsFlowControl: a throw in a lambda invoked by the method it is passed to

#7105 stopped the walk at every lambda body. That fixed the false positive of
#4815, but it also stopped reporting a throw inside a lambda that the method it
is passed to calls itself. spring-framework's
LeakAwareNettyDataBufferFactory#checkForLeaks (v5.3.13, line 56) throws inside
Iterable.forEach and catches the exception right below.

The walk now continues through a lambda that is an argument of a call whose
method calls that argument: Iterable.forEach, Iterator.forEachRemaining,
Map.forEach, Optional.ifPresent/ifPresentOrElse, and the Stream methods that
take a lambda argument. A terminal operation calls the action while the call is
evaluated; an intermediate operation is evaluated by the terminal operation of
the same pipeline. Every other lambda stays opaque, so #4815 does not come back.

Signed-off-by: Eljees <3.14hell@gmail.com>

* Use compound invocation matcher and clarify release notes

* [java] Handle primitive streams in ExceptionAsFlowControl

---------

Signed-off-by: Eljees <3.14hell@gmail.com>

20278 of 26472 branches covered (76.6%)

Branch coverage included in aggregate %.

7 of 8 new or added lines in 1 file covered. (87.5%)

43610 of 53647 relevant lines covered (81.29%)

0.82 hits per line