valkyrjaio / valkyrja-php / 36809015965

100%

push

github

[Config] feat!: Give each log adapter its own logger setting (#1333)

# Description

Give the log adapter of every component its own logger setting, and
start each logger property name with the component name. Before this
change, `LogClient`, `LogMailer`, `LogMessenger` and `LogSession` always
wrote to the application's default logger. Cache and Broadcast had a
setting, but both named it `logLogger`, so one application config class
could hold only one logger for both.

HttpClient, Mail, Sms and Session each get a log adapter config contract
and a default implementation. The service provider publishes each one as
its own binding, and each log adapter resolves its logger from that
binding. Every default is `LoggerContract::class`, so an application
that sets nothing keeps the application's default logger.

This breaks an application config that implements
`CacheLogConfigContract` or `BroadcastLogConfigContract`. Rename
`logLogger` to `cacheLogLogger` or to `broadcastLogLogger`, and rename
`logPrefix` to `cacheLogPrefix`.

## Types of changes

- [ ] Improvement _(non-breaking change which improves code)_
- [ ] Bug fix _(non-breaking change which fixes an issue)_
- [x] New feature _(non-breaking change which adds functionality)_
- [ ] Deprecation _(breaking change which removes functionality)_
- [x] Breaking change _(fix or feature that would cause existing
functionality to change)_
- [ ] Documentation improvement

## Changes

- **Cache, Broadcast** — rename `logLogger` to `cacheLogLogger` and to
`broadcastLogLogger`, and rename Cache's `logPrefix` to
`cacheLogPrefix`, so both properties in that contract follow one rule.
- **HttpClient, Mail, Sms, Session** — add a log adapter config contract
and its default implementation, publish the contract as its own binding,
and build the log adapter from it.
- **`README.md`** — each component documents its log config contract and
binding, and the Http README documents the client's log config.
- **Tests** — cover ea... (continued)

63 of 63 new or added lines in 10 files covered. (100.0%)

13067 of 13067 relevant lines covered (100.0%)

26.17 hits per line