ThePalaceProject / web-patron / 36756800194

27%

Build Type

push

github

Committed by web-flow

Commit Message

Support for pin reordering (PP-3116) (#205)

## Description

Adds reordering of pinned libraries ("My Libraries") on the
multi-library home page. It is behind the existing
`PALACE_CPW_FEATURE_PINNING` feature flag.

- **Reorder mode:** a **Reorder** button next to the "My Libraries"
heading when two or more pinned libraries are shown. In reorder mode it
reads **Done**.
- **In reorder mode, each pinned card shows:**
  - a grip handle for mouse dragging;
- stacked **Move up** and **Move down** buttons for keyboard use. At
either end of the list the matching button is disabled but stays
focusable.
- **In reorder mode, the cards:**
- show the library name as plain text, so clicking a card does not open
the library;
  - have no hover effect;
  - show no pin button.
- **Moves:**
  - the new order is saved to the browser right away;
- moves are announced to screen readers ("Alpha Library moved to
position 2 of 3.");
  - after a button move, focus stays on the pressed button.
- **Hidden pins:** moves go to the position of a target library by id.
So pinned libraries that are stored but not shown (missing from the
server list) do not throw moves off.
- **Item landing page:** shows the pinned order but offers no
reordering.
- **New dependencies:** `@dnd-kit/core`, `@dnd-kit/sortable`,
`@dnd-kit/utilities`.
- **Translations:** new strings in French, Italian, German, and Spanish.
The reorder terms are added to the translation glossary.

> [!IMPORTANT]
> This branch is stacked on #203, which is, in turn, stacked on #202.
Those must land before this PR is merged.

## Motivation and Context

Patrons who pin several libraries may want their most used or preferred
library(ies) first.

[Jira PP-3116]

## How Has This Been Tested?

- Manually tested in local dev environment (in Chromium and Safari
browsers).
- New tests for the new functionality.
- All tests / checks pass locally and [in
CI](https://github.com/ThePalaceProject/web-patron/actions/runs/36370541703).

## Ch... (continued)

Coverage Stats

354 of 1772 branches covered (19.98%)

Branch coverage included in aggregate %.

7 of 67 new or added lines in 7 files covered. (10.45%)

2 existing lines in 1 file now uncovered.

764 of 2475 relevant lines covered (30.87%)

8.59 hits per line