ThePalaceProject / web-patron / 36523683808

27%

Build Type

push

github

Committed by web-flow

Commit Message

Basic pinning support (PP-3116) (#203)

## Description

Adds basic library pinning, behind a new feature flag.

- **Feature flag:** set the `PALACE_CPW_FEATURE_PINNING` environment
variable to `true` to enable pinning. It is off by default; while off,
pin controls are hidden and stored pins are ignored. The flag is
documented in the README with the other feature flags.
- **Pin and unpin** from a library's page (header, next to the language
selector) and from each card on the multi-library home page. The item
landing page has no pin controls.
- **My Libraries** section above the search on the home page and the
item landing page. It lists pinned libraries in pinned order and leaves
out any that are no longer available.
- **With pins shown:** the search heading becomes "Find another
library:" and the full library list shows only while the search box
holds text. Pinning or unpinning from the home page clears the search.
- **Public computer warning** on the first pin, with a "Do not show this
again." option and a "Reset the shared computer warning" button in My
Libraries.
- **Unpinning a library the user is signed in to** asks for confirmation
and signs out. From the library page this runs the full sign-out flow,
now shared with the Sign Out button through a new `useSignOutFlow` hook.
From the home page it clears the stored credentials only.
- **Accessibility:**
  - Pin and unpin are announced to screen readers.
- When the pressed button disappears, focus moves to the library's new
button, a neighboring library's button, or the heading.
- The dialogs are named and described by their visible heading and
message.
  - The search box is named by its heading.
- **Shared pieces:** an `AlertDialog` component for confirmation
dialogs; `LibraryCard` gains a slot for the pin button.
- **Dialog fix:** dialogs and their backdrop now sit on the theme's
`modal` layer, so page content no longer shows through. This applies to
all dialogs.
- **Translations:** new strings i... (continued)

Coverage Stats

354 of 1707 branches covered (20.74%)

Branch coverage included in aggregate %.

17 of 227 new or added lines in 18 files covered. (7.49%)

7 existing lines in 4 files now uncovered.

757 of 2416 relevant lines covered (31.33%)

8.8 hits per line