solidjs / solid / 36746432090

76%

main: 89%

push

github

fix(signals): a run that committed undefined is not WASTED_RECOMPUTE (#3716)

* fix(signals): a run that committed undefined is not WASTED_RECOMPUTE

A projection that mutates its draft, or a memo that does its work by
writing a signal, commits undefined on every run, so the equality gate
always closed and the re-runs were counted as wasted. The rule that
undefined outputs are exempt only applied to effects.

recomputeEnd now passes a separate noValue flag to checkWastedRecompute;
changed, costs and records are unchanged.

Fixes #3715

* fix(signals): report undefined-output runs as changed so every waste consumer agrees

The exemption for runs that commit `undefined` lived only inside
checkWastedRecompute, so the RerunEvent still said `changed: false` and
costs().wastedMs, expectNoWaste, the performance tracks and the why-run
log kept counting projection and writing-memo runs as waste. Apply it to
`changed` in recomputeEnd instead, mirroring the effect-output rule, and
drop the noValue parameter. This is the documented behavior: an
`undefined`-output compute reports `changed: true` and is exempt.

Co-authored-by: Claude via Cursor <noreply@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>

---------

Co-authored-by: Ryan Carniato <ryansolid@gmail.com>
Co-authored-by: Claude via Cursor <noreply@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>

649 of 925 branches covered (70.16%)

Branch coverage included in aggregate %.

962 of 1195 relevant lines covered (80.5%)

27.77 hits per line