solidjs / solid / 36740477759

76%

main: 89%

push

github

fix(solid): hydration trace's fake Promise provides withResolvers and try (#3727)

During hydration adoption, subFetch runs the compute once under a
never-settling fake `Promise` to record its dependencies. The fake had
no `withResolvers` or `try`, so a traced compute calling either threw
out of hydration instead of adopting the server value.

- `withResolvers` returns a never-settling fake with no-op
  `resolve`/`reject`.
- `try` returns a never-settling fake without invoking its callback,
  matching the fake constructor, which ignores its executor.

Every other standard static and prototype method was already present.

Size-Exception accepted by the maintainer: the two frozen page caps
rise to fit (+67 B minified; brotli +99 B / +96 B):
- page: base server components: 45.95 -> 46.04 KB
- page: live server components: 50.12 -> 50.17 KB

Co-authored-by: Claude via Cursor <noreply@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>

649 of 925 branches covered (70.16%)

Branch coverage included in aggregate %.

2 of 2 new or added lines in 1 file covered. (100.0%)

962 of 1195 relevant lines covered (80.5%)

27.69 hits per line