NVIDIA / nodewright / 36743133578
82%

DEFAULT BRANCH: main
Ran
Jobs 1
Files 59
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 82.265% (-0.2%) from 82.424%
36743133578

push

github

web-flow 
feat(agent)!: cut over to the Go agent and remove the Python implementation (#685)

The production agent image now builds from the Go module, which moves from
agent/go/ up to agent/ so the on-disk path matches the module path
github.com/NVIDIA/nodewright/agent that #213 chose with this moment in mind.
No Go import changes; git records the move as renames. The Python source under
agent/skyhook-agent/, its vendored dependency, hatch.toml and the Python
Makefile are deleted in the same commit so the history reads as one swap.

containers/agent.Dockerfile is the former agent-go.Dockerfile: a static
CGO_ENABLED=0 build into distroless/static. agent-ci.yaml is the former
agent-go-ci.yaml with the pieces only the Python workflow had folded in: the
agent/* tag trigger, the tag-versus-branch version computation, and the
cosign signing, SBOM, provenance attestation and verification steps gated on
release tags. The operator-agent suite job keeps the strict both-directions
ci-gate shape. Everything that pointed at agent/go/ (root Makefile notices
targets, merge-gate filters and license jobs, codeql, lint-ci exclude paths,
renovate rules, the openvex skill) points at agent/. codeql drops its Python
matrix entry, renovate drops the pep621 rules, and the notices generator
loses its pip-licenses pass; the agent notices are regenerated as Go-only and
their vendor links resolve now that the module path mirrors the directory.

The agent Makefile gains a docker-build target so the local image build the
Python Makefile offered does not disappear with it.

agent/RELEASE_NOTES.md records the change and the three behaviours that differ
from v6.x: on_host: false now takes effect (the Python agent printed the flag
but chrooted every step), host log files lose the [out]/[err] line prefix, and
SKYHOOK_AGENT_BUFFER_LIMIT is gone. It also gives the rollback (pin the image
back to v6.4.2) and its one caveat: a node whose reboot the Go agent started
but had not yet confirmed by boot... (continued)

9333 of 11345 relevant lines covered (82.27%)

7.62 hits per line

Coverage Regressions

Lines Coverage ∆ File
20
79.62
-0.84% operator/internal/controller/skyhook_controller.go
Jobs
ID Job ID Ran Files Coverage
1 36743133578.1 59
82.27
GitHub Action Run
Source Files on build 36743133578