hyperledger-labs / fabric-smart-client / 36715321830

91%

Build Type

push

github

Committed by web-flow

Commit Message

fix(fabric): use the proposal's chaincode version in self-endorsed responses and increase transaction coverage (#1972)

getProposalResponse initialized the version from the chaincode name, so
a proposal carrying an explicit version produced a proposal response
whose ChaincodeId.Version was the chaincode name. It now uses the
proposal's chaincode version and asks the channel's chaincode manager
for the version only when that version is empty.

Increase coverage of platform/fabric/core/generic/transaction: the
decode and validation error paths of envelopes, signed proposals and
proposal responses, self-endorsement (proposal and response signing,
rws lifecycle, duplicate endorsers, chaincode version lookup), envelope
assembly, SetRWSet sources, serialization errors, and the manager's
factory dispatch.

Fixes #1937

Signed-off-by: Said Altury <Said.Altury@ibm.com>

Coverage Stats

2 of 2 new or added lines in 1 file covered. (100.0%)

3 existing lines in 2 files now uncovered.

28987 of 32087 relevant lines covered (90.34%)

2357.27 hits per line