hyperledger / fabric-x-committer / 36708841439

91%

main: 91%

Pull #842

github

[sidecar] Make the block store transaction ID index optional

#### Type of change

- New feature
- Improvement (improvement to code, performance, etc)

#### Description

- Add `ledger.disable-tx-id-index` to the sidecar config, defaulting to false so the block
  store keeps indexing transaction IDs as before.
- Take `*LedgerConfig` in `newBlockStore` instead of the path and sync interval, and build
  the `blkstorage.IndexConfig` from it.
- Document the option in the sample config and under the Sidecar section of
  `docs/performance-tuning.md`.

#### Additional details (Optional)

The flag is opt-out rather than opt-in so that a zero-valued `LedgerConfig`, which is how
tests and any other in-Go caller build one, still indexes everything.

The block number index is deliberately not configurable. The block store reads the last
block header through it when it opens a non-empty ledger, so a sidecar without it cannot
recover from a restart. `TestBlockStoreReopenWithoutTxIDIndex` pins that reopen path.

Disabling the transaction ID index costs `GetBlockByTxID` and `GetTxByID`, so it suits a
sidecar that serves neither. The index also selects the block store's on-disk format, so
changing the setting requires an empty ledger directory.

#### Related issues

- resolves #784

Signed-off-by: Liran Funaro <liran.funaro@gmail.com>

9 of 10 new or added lines in 2 files covered. (90.0%)

9772 of 10775 relevant lines covered (90.69%)

10528.03 hits per line