panates / rman / 36687846814

95%

push

github

fix(cli): keep the inherited environment when a status region forces a pipe

`BinPath.env`'s `env` option is the environment to *derive from* - it stands
in for `process.env` rather than extending it - and the status region's
`FORCE_COLOR` was handed over as that whole environment. Every `runBin` call
made while a region is live therefore spawned its child with one variable and
a PATH holding nothing but the contributed directories.

Shipped in 2.3.0, and since a region is live for every command, that is every
`runBin` call: the preset's `test`, and any `.rman/*.mjs` command or function
step that uses it.

Measured on `panates/sqb`: `rman test` still found npm - the node walk ends at
the running interpreter's own directory, where npm sits - and npm then died
with `spawn sh ENOENT`, because `/bin` was not on the PATH it was given.

A binary run straight out of `node_modules/.bin` survives a PATH like that
(its `#!/usr/bin/env node` shebang resolves by absolute path, and `node` is
the one entry the walk appends), so the preset's `lint`, `check` and `format`
were green throughout. What fails is a child that spawns a shell of its own -
`npm run` being the one every repository types. The spec therefore runs
something that spawns `sh` itself; with the fix reverted it is the one case
of 1078 that fails.

A region is only live on a TTY, so CI was never affected.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>

2978 of 3263 branches covered (91.27%)

Branch coverage included in aggregate %.

8 of 8 new or added lines in 1 file covered. (100.0%)

17970 of 18947 relevant lines covered (94.84%)

200.08 hits per line