panates / rman / 36684614407

95%

Build Type

push

github

Committed by erayhanoglu

Commit Message

feat(cli): let a contributed command take the build and test aliases

`rman test` is an alias for `run test`, which fans the script out over the
repository's packages. Measured across seven repositories of this organization: not
one has a package with its own `test` script, because testing there is a single run
at the repository root - exactly as linting is a single eslint run there. So
`rman test` answered `No package defines a "test" script.` and everyone typed
`npm test` instead, leaving one verb outside the set (`rman check`, `rman lint`,
`rman format`, `rman build`, and then `npm test`).

Declaring a `test` command to fix that used to throw "would shadow rman's built-in".
That is the wall `lint` hit, which is why `lint` is not an alias any more - and the
note beside `build`/`test` said they were "in the same bind... just not one anybody
has hit". Now hit.

`build` and `test` are the only built-ins that carry no logic of their own, so the
name belongs to whoever has the better answer. `shadowable` says so on the
declaration, `builtInNames` leaves those out, and the existing "one registration per
name, keeping the last" rule does the rest.

Deleting the `test` alias outright would have been the cleaner surface and a major -
for the benefit of nobody, since it has zero invocations anywhere, only
documentation. Shadowing reaches the same place without breaking a repository whose
tests really are per package, which still has `rman run test`.

**A shadowed built-in is not registered at all**, and that part is not optional:
letting yargs' last-wins settle it leaves two rows in `--help`, each with its own
description and nothing saying which runs - measured, with rman's alias and
@panates/rman-preset's command both listed. Same failure `byName` already fixed for
contributed-on-contributed, same fix: skip the registration, say so at verbose.

Two spec traps, both caught by asking what would actually fail. A case passing a
hand-written list to `assertNoBui... (continued)

Coverage Stats

2970 of 3260 branches covered (91.1%)

Branch coverage included in aggregate %.

70 of 70 new or added lines in 4 files covered. (100.0%)

19 existing lines in 6 files now uncovered.

17961 of 18940 relevant lines covered (94.83%)

200.14 hits per line