source-academy / frontend / 36679325354

46%

Build Type

push

github

Committed by web-flow

Commit Message

fix(remoteExecutionConductor): resolve EV3 evaluator from the language directory (#4407)

* fix(remoteExecutionConductor): resolve EV3 evaluator from the language directory instead of a hardcoded local path

The EV3 evaluator script was loaded from a hardcoded bundled path
(/evaluators/ev3-remote-runner.js), unlike every other evaluator
(Py2JS, PyStepper, CSE machine), which are fetched live from the
language directory. Adds an EV3 capability so the evaluator can be
looked up the same way, falling back to the local bundled copy if no
matching directory entry exists yet.

Classic (non-module) Workers enforce same-origin loading regardless of
CORS, so a cross-origin directory URL can't be passed to `new
Worker(url)` directly - works around this by fetching the script
ourselves and constructing the Worker from a same-origin Blob URL.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01UfpKt8WtJCGZHiETgDXmYu

* fix(remoteExecutionConductor): address CodeRabbit review on the EV3 evaluator fetch/run path

Three real gaps introduced by making createEv3Conductor async (it now
awaits a network fetch, where it used to be synchronous):

- fetch() only rejects on network failure, not HTTP error status, so a
  404/error response body could silently become the Worker's script.
  Check response.ok before reading it.
- createEv3Conductor or plugin.run throwing inside handleConductorRun
  was uncaught, which could bubble through the attached saga tree and
  stop the whole conductor watcher instead of just failing that run.
  Wrap both in try/catch and report via the existing
  evalInterpreterError/isRunning:false path.
- The session can disconnect or switch clients while createEv3Conductor
  awaits its fetch - re-check the current session/client before
  caching the newly created conductor, terminating it instead if the
  session moved on.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: htt... (continued)

Coverage Stats

3190 of 7942 branches covered (40.17%)

Branch coverage included in aggregate %.

5 of 33 new or added lines in 4 files covered. (15.15%)

1 existing line in 1 file now uncovered.

7207 of 14781 relevant lines covered (48.76%)

31.75 hits per line