hyperledger / fabric-x-committer / 36674936712

91%

main: 91%

Build Type

Pull #826

github

Committed by cendhu

Commit Message

[vc, sidecar] Delete a snapshot database clone on admin request

#### Type of change

- New feature
- Documentation update

#### Description

- Adds `DeleteDBCloneForSnapshot(tx_id)`, propagating sidecar → coordinator → VC.
  The VC drops the database named by the `_snapshot` record's `clone_database`
  field and clears that field via a versioned namespace write; clearing it *is*
  the deletion signal, since `SnapshotState` carries no deletion timestamp. The
  record is retained, so the snapshot's status and hash stay queryable after its
  database is gone.
- Deletion is refused unless the snapshot's status is `CHECKPOINTED`
  (`FAILED_PRECONDITION`). Until then the clone is the only artifact from which
  the snapshot hash can be recomputed or a contested hash re-verified, so
  dropping it would be unrecoverable.
- Reports `INVALID_ARGUMENT` for an empty `tx_id` and `NOT_FOUND` for an unknown
  one. A repeated delete of an already-cleared record succeeds: the caller cannot
  distinguish a retry of its own request from a duplicate, and both mean the
  database is gone. That check precedes the status gate, so a retry of a delete
  that already succeeded stays a success.
- Adds `ClearCloneDatabase` to `statedb.SnapshotUpdate`, so the deletion path can
  clear `clone_database` through the shared `_snapshot` record accessor. The clear
  re-asserts `CHECKPOINTED` and sets `ExpectedStatus` to it, so the locked row must
  still be `CHECKPOINTED` for the clear to apply.
- Adds `statedb.SnapshotStateManager.Read(tx_id)` and the `statedb.ErrSnapshotNotFound`
  sentinel it reports, extracted from `ReadLatest`'s read-and-decode step so both agree
  on how a missing row and an undecodable value are reported. `ReadLatest` keeps
  treating a missing row as corruption, since its key comes from the pointer rather
  than from a caller.
- Records `DeleteDBCloneForSnapshot` calls in one embedded `mock.deleteCloneRecorder`
  shared by the mock coordinator and the mock vcse... (continued)

Pull Request Pull Request #826: [vc, sidecar] Delete a snapshot database clone on admin request

Coverage Stats

94 of 97 new or added lines in 9 files covered. (96.91%)

23 existing lines in 6 files now uncovered.

9847 of 10845 relevant lines covered (90.8%)

21829.99 hits per line