thoughtspot / mcp-server / 36671765292

90%

push

github

SCAL-320648 mcp changes to support spotter model through tools (#197)

* SCAL-320648 mcp changes to support spotter model through tools

* SCAL-320648 mcp changes to support spotter model through tools

* SCAL-320648 address MCP review feedback on the Spotter Model tools

Rework the Spotter Model feature per review comments on #197:

- Split the merged send_model_message into create_model_session /
  send_model_message / get_model_updates, mirroring the analytical-session
  trio, with finalize_model as the terminal save (like create_dashboard).
  get_model_updates keeps a ~60s poll window since a build runs 1-2 min.

- Drop the parallel model-update stream in the conversation storage DO:
  model updates now ride the same append/read-bookmark message stream as
  Spotter, isolated by conversation id, with the per-turn
  initializeConversation replacing resetDone. What remains is one generic
  opaque /state route for the session's transaction id and generation
  working set. Also skips the read-bookmark write on an idle poll, which
  benefits the V2 path too.

- Move the feature into src/thoughtspot/spotter-model/ following the
  search-objects layout. The stream consumer writes through a
  ModelStreamSink, so the thoughtspot layer no longer imports storage.

- Gate all four tools on data-modeling privileges (DATAMANAGEMENT,
  CAN_MANAGE_WORKSHEET_VIEWS_TABLES, ADMINISTRATION), fail-closed: filtered
  from listTools, and rejected in dispatchTool too since client tool lists
  are cached and can outlive a privilege change.

Also fixes a duplicated toolDefinitionsV3 block that made the branch fail to
build at all, and adds the tests the feature was missing: 815 passing,
coverage 92.1% statements / 87.5% branches (was 78.4/72.1, under the 85%
gate that CI enforces).

Two behavior changes worth noting: a second instruction sent while a turn is
still streaming is now rejected rather than interleaving two turns' updates,
and polling before any instruction was s... (continued)

1246 of 1424 branches covered (87.5%)

Branch coverage included in aggregate %.

352 of 366 new or added lines in 12 files covered. (96.17%)

2176 of 2367 relevant lines covered (91.93%)

1288.21 hits per line