OpenCHAMI / ochami / 36641633543

93%

Build Type

push

github

Committed by web-flow

Commit Message

fix(metadata): fix nil-pointer panic in patch commands from wrong flag name (#159)

metadata {defaults,group,instance,peer} patch's --set/--unset/--add/
--remove branch checked cmd.Flag("patch-format").Changed, but no flag
by that name is registered on these commands — the actual flag is
"patch-method" (Flags().VarP(&formatPatch, "patch-method", ...) a few
lines below), matching what the command's own Long/Example text and
its boot command family equivalent (cmd/boot/{bmc,config,node}/
patch.go, which correctly checks "patch-method") already call it.
cmd.Flag() returns nil for an unregistered name, so calling .Changed
on it panicked.

This made ochami metadata <resource> patch <id> --set k=v (the
documented dot-notation shorthand patch, one of each command's own
Example entries) crash unconditionally, regardless of whether
--patch-method was itself passed.

Signed-off-by: Devon Bautista <17506592+synackd@users.noreply.github.com>

Coverage Stats

0 of 12 new or added lines in 4 files covered. (0.0%)

24 existing lines in 4 files now uncovered.

1906 of 15803 relevant lines covered (12.06%)

0.86 hits per line