GavinHuttley / scinexus / 36628730773
100%

DEFAULT BRANCH: main
Ran
Jobs 0
Files 0
Run time –
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
36628730773

push

github

GavinHuttley 
BUG: id_from_source given to as_completed or apply_to is an app setting

apply_to stashed a propagate_source wrapper built from its id_from_source and
never cleared it, so as_completed reused it forever: after
apply_to(id_from_source=A), as_completed(id_from_source=B) named results
A_item_0 instead of B_item_0. Recomposing an applied writer was worse, since
__add__ copies the writer but gives it a fresh input, leaving a non-None
wrapper with a None payload and raising TypeError: 'NoneType' object is not
callable on the next run.

The wrapper is gone. Both methods record their argument in
_id_from_source_override and _resolve_id_from_source reads it ahead of the
writer's constructor argument, so the two agree however either is called.
as_completed records before returning its generator rather than on first
iteration, and apply_to records only once its own checks have passed, so a
refused call leaves the app as it was.

The override is read for every app type, unlike the constructor argument,
which stays writer-only. It is not merged into _supplied_args because __copy__
shares that dict across composition. The name avoids _id_from_source, which
cogent3's writers assign themselves and which is not reserved. apply_to's
'app_type is WRITER' test went too: it is reachable only by subclassing
WriterApp and overriding _default_app_type, and both the old and new
behaviours are errors there.
Source Files on build 36628730773
Detailed source file information is not available for this build.