GavinHuttley / scinexus / 36565533113

100%

push

github

API: a writer's own id_from_source names the records it writes

__call__ and apply_to derived every record name from get_id_from_source() and
injected it as identifier, so a writer doing 'identifier or
self._id_from_source(data)' never ran its own extractor. Built as
write_seqs(dstore, id_from_source=first_part) over a source of
dummy/blah.1.2.fa, the writer named the record blah.1.fa when called and
blah.fa through main.

__call__, apply_to and as_completed now resolve through
_resolve_id_from_source, which prefers the id_from_source argument the writer
was constructed with. All three had to move together or the two paths would
still disagree. The extractor is read from that argument rather than from the
instance attribute cogent3 stores it in.

Only writers are consulted, since id_from_source means whatever its author
chose on any other app type. Two consequences are in the changelog: a supplied
extractor must be picklable under parallel=True, and apply_to derives its
already-done key with it. Both already applied to apply_to's own argument.

8 of 8 new or added lines in 1 file covered. (100.0%)

2961 of 2967 relevant lines covered (99.8%)

8.86 hits per line