solidjs / solid / 36626162808

76%

main: 89%

push

github

types: until's AbortSignal resolves without the DOM lib

`until`'s `signal` option named the global `AbortSignal` in both
@solidjs/signals (`UntilOptions`) and solid-js's server `until`
(reachable from `solid-js/internal` through `server/shared`). That
global exists only in the DOM/WebWorker libs or `@types/node`, so a
server or worker consumer with neither and `skipLibCheck: false` got
TS2304 from the published declarations, including plain `solid-js`,
which re-exports `until` from @solidjs/signals.

The option now types through a module-local alias that looks the
global up on `typeof globalThis`: it is exactly `AbortSignal` wherever
a lib declares one (still assignable to `fetch`'s `signal`), and
otherwise the abort surface `until` actually uses. The server `until`
takes `UntilOptions` instead of repeating the inline shape. No exports
change.

The published-declarations guard now also compiles every entry, plus
@solidjs/signals's, under `lib: es2022` with no `@types/node`, and its
DOM run passes an `UntilOptions` signal to `fetch`, so a structural
stand-in that `fetch` would reject fails it.

Co-authored-by: Cursor <cursoragent@cursor.com>

625 of 912 branches covered (68.53%)

Branch coverage included in aggregate %.

936 of 1186 relevant lines covered (78.92%)

27.23 hits per line