solidjs / solid / 36599896377

76%

main: 89%

push

github

Move sharedConfig and $DEVCOMP types to solid-js/internal; guard index.d.ts against stripped re-exports

Follow-up to #3709. `sharedConfig` and `$DEVCOMP` were tagged `@internal`
at their declarations but re-exported from a public block of `solid-js`'s
index, so `types/index.d.ts` still carried two dangling re-exports (TS2305
under skipLibCheck: false, `any` otherwise).

Both move to the index's `@internal` block, so they remain runtime exports
of `solid-js` on every build. `solid-js/internal` now declares them:
`sharedConfig` gets one shape that is honest for both entries (every member
optional, since the client object carries hydration state and the server
object carries the render `context` and the id allocator), and `$DEVCOMP`
is declared as `symbol`. The server entry tags the same names, plus
`createErrorBoundary`, `createLoadingBoundary` and `createRevealOrder`,
`@internal` the same way. Every in-repo consumer (web, frames, refresh,
web tests) now imports them from `solid-js/internal`.

published-declarations.spec.ts compiles a probe over every published types
entry with skipLibCheck: false and requires the generated declarations to
check clean. That covers this whole class of stripInternal bug, not just
these names. internal-surface.spec.ts now pins the three boundary
primitives, `sharedConfig` and `$DEVCOMP`.

The REACTIVITY_HALTED message and its docs now point to `<Errored>` only.

Co-authored-by: Claude via Cursor <noreply@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>

625 of 912 branches covered (68.53%)

Branch coverage included in aggregate %.

2 of 2 new or added lines in 1 file covered. (100.0%)

936 of 1186 relevant lines covered (78.92%)

27.36 hits per line