vuepress / core / 36579630257

74%

push

github

fix(bundler-webpack): externalize vue subpaths in ssr bundle (close #1718) (#1725)

The server bundle only externalized `vue` itself. The array form of
webpack `externals` matches requests exactly, so `vue/server-renderer`,
which SFCs compiled for SSR import from, was resolved to
`@vue/server-renderer` and bundled together with its own copies of
`@vue/runtime-core` and `@vue/shared`, while `vue` stayed external.

With two vue runtimes in one server bundle, components are created by
the bundled runtime, and `instance.refs` is the bundled `EMPTY_OBJ`,
but `useTemplateRef` comes from the external `vue` and compares it with
its own `EMPTY_OBJ`. With the production build of vue, the check never
matches, so the ref is defined as a non-configurable property on the
shared `EMPTY_OBJ`, and rendering another page that uses the same ref
key throws `Cannot redefine property`, leaving the page content empty
in the generated HTML.

Externalize `vue` and all of its subpaths. `@vue/*` packages are not
externalized, because they are not guaranteed to be resolvable from the
temp directory with pnpm, e.g. `@vue/devtools-api`.

412 of 552 branches covered (74.64%)

Branch coverage included in aggregate %.

800 of 1087 relevant lines covered (73.6%)

48.34 hits per line