vuepress / core / 36579459234

74%

push

github

fix(vuepress): set NODE_ENV before loading bundler in bin shorthands (#1723)

`vuepress-vite` and `vuepress-webpack` imported the bundler statically,
so it was evaluated before the `dev` / `build` command set the default
`NODE_ENV`. The bundlers load `vue` at module top level (e.g.
`@vuepress/bundlerutils` imports `ssrContextKey` from `vue`, and
`@vitejs/plugin-vue` / `vue-loader` load `vue` / `vue/compiler-sfc`),
and the CJS entries of `vue` and `@vue/*` pick their development or
production builds by `NODE_ENV` when first required.

As a result, `vuepress-vite build` and `vuepress-webpack build` ran with
the development builds of the Vue runtime and template compiler, while
`vue/server-renderer`, imported later for SSR, used its production
build, mixing both in one process. SSR was noticeably slower, and the
output differed from `vuepress build` with the bundler set in the config
file, e.g. the dev compiler kept HTML comments of Markdown pages.

Set the default `NODE_ENV` according to the command in these bins, and
import the bundler and the cli dynamically afterwards. An explicitly
provided `NODE_ENV` is still respected, and other commands and options
are left to the cli as before.

412 of 552 branches covered (74.64%)

Branch coverage included in aggregate %.

800 of 1087 relevant lines covered (73.6%)

48.34 hits per line