tari-project / tari / 36550566220

71%

Build Type

push

github

Committed by web-flow

Commit Message

refactor(ledger): shared wire-format codec for every APDU layout (#8056)

Description
---
Makes `minotari_ledger_wallet_common` the single definition of every
Ledger APDU wire layout: commands, replies, and the `GetScriptOffset`
chunk assembly. The host encoders (`comms/src/accessor_methods.rs`) and
the device decoders (`wallet/src/handlers/*.rs`) both call it.

This is a pure refactor of the wire format. **Every byte on the wire is
unchanged**, and every device check fires in the same order with the
same status word. The one intentional behaviour change is the security
fix described below.

- **Codec:** `common/src/codec/`.
- Decoding is zero-copy: `&'a [u8; N]` fields borrowed from the APDU
buffer, with no indexing that can panic.
- Encoding writes into an `impl Writer` sink. A host-only `to_vec()`
sits behind a new `alloc` feature, which the device doesn't enable.
- Boundary types are raw bytes, `u64` and `u8` only, with no
`tari_crypto` dependency. The codec frames the data; it does not
validate it. Canonical-bytes checks stay at each edge.
- **Shared constants:** `CLA` and `RESPONSE_VERSION` are each one
constant in `common::codec`. This replaces `WALLET_CLA`/`CLA` and
`EXPECTED_RESPONSE_VERSION`/`RESPONSE_VERSION`.
- **Raw escape hatch:** `build_command` and `build_chunk_command` move
to `comms::raw`, documented as being for payloads the typed encoders
refuse to construct. They are not sealed, because the ledger demo and
the Speculos scenarios use them to send deliberately malformed chunk
sequences.
- **Registry test:** an exhaustive `match` over `Instruction`. Adding a
variant without an encoder fails to compile.
- **Cleanups:** `Bip32Path` (dead code) is deleted. `u64_to_string`
moves into `common`, with no panic path and edge tests.

The commits follow the planned landing order and are meant to be
reviewed one at a time. The golden vectors pass unchanged at every
commit.
1. `test(ledger): golden encode vectors for every instruction`. This
add... (continued)

Coverage Stats

1189 of 1199 new or added lines in 12 files covered. (99.17%)

985 existing lines in 26 files now uncovered.

92595 of 144962 relevant lines covered (63.88%)

771625.64 hits per line