tari-project / tari / 36461308808
71%

DEFAULT BRANCH: development
Ran
Jobs 1
Files 783
Run time 2min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 64.016% (+0.4%) from 63.574%
36461308808

push

github

web-flow 
feat: harden mempool (#8055)

Description
---
Changes how the mempool processes new transactions in order to harden it
to be more resilient.

<!-- greptile_comment -->

<!-- greptile_summary -->

<h2><a
href="https://app.greptile.com/api/retrigger?id=70659129"><picture><source
media="(prefers-color-scheme: dark)"
srcset="https://greptile-static-assets.s3.amazonaws.com/badges/RetriggerDark.svg?v=2"><source
media="(prefers-color-scheme: light)"
srcset="https://greptile-static-assets.s3.amazonaws.com/badges/Retrigger.svg?v=2"><img
alt="Retrigger"
src="https://greptile-static-assets.s3.amazonaws.com/badges/Retrigger.svg?v=2"
align="right"></picture></a>Confidence Score: 4/5</h2>

<!-- greptile-risk -->

The PR should not merge until validation failures are rechecked when the
chain changes during validation.

<h2><a
href="https://app.greptile.com/ide/claude-code?prompt=%23%23%23%20Issue%201%0Abase_layer%2Fcore%2Fsrc%2Fmempool%2Fmempool_storage.rs%3A160-161%0AIf%20a%20block%20or%20reorg%20is%20processed%20while%20a%20transaction%20is%20being%20validated%2C%20a%20script%20that%20fails%20against%20the%20captured%20old%20tip%20may%20be%20valid%20at%20the%20new%20tip.%20This%20path%20returns%20the%20failure%20before%20checking%20whether%20the%20chain%20changed.%20The%20wallet%20can%20then%20cancel%20a%20valid%20transaction%20instead%20of%20having%20it%20revalidated.%0A%0A---%0A%0AFor%20each%20issue%20above%2C%20determine%20whether%20it%20is%20valid%20and%20should%20be%20fixed.%20If%20so%2C%20fix%20it%20directly.&repo=tari-project%2Ftari&pr=8055&platform=github"><picture><source
media="(prefers-color-scheme: dark)"
srcset="https://greptile-static-assets.s3.amazonaws.com/badges/FixAllInClaudeDark.svg?v=7"><source
media="(prefers-color-scheme: light)"
srcset="https://greptile-static-assets.s3.amazonaws.com/badges/FixAllInClaude.svg?v=7"><img
alt="Fix All in Claude Code"
src="https://greptile-static-assets.s3.amazonaws.com/badges/FixAllInClaude.svg?v=7"
align="righ... (continued)

970 of 1010 new or added lines in 11 files covered. (96.04%)

48 existing lines in 13 files now uncovered.

92193 of 144015 relevant lines covered (64.02%)

404999.88 hits per line

Uncovered Changes

Lines Coverage ∆ File
31
88.89
16.48% base_layer/core/src/mempool/mempool_storage.rs
7
81.4
-14.76% base_layer/core/src/validation/transaction/transaction_full_validator.rs
1
87.73
14.77% base_layer/core/src/mempool/mempool.rs
1
88.65
1.6% infrastructure/tari_script/src/stack.rs

Coverage Regressions

Lines Coverage ∆ File
17
55.36
1.3% base_layer/core/src/chain_storage/lmdb_db/lmdb_db.rs
5
55.58
-0.62% base_layer/core/src/base_node/comms_interface/inbound_handlers.rs
5
82.14
-0.99% comms/core/src/noise/socket.rs
4
88.57
-0.57% base_layer/core/src/validation/block_body/test.rs
4
61.03
-0.98% base_layer/core/src/validation/helpers.rs
3
60.31
3.94% base_layer/core/src/chain_storage/blockchain_database.rs
2
88.89
16.48% base_layer/core/src/mempool/mempool_storage.rs
2
87.14
-0.2% base_layer/core/src/proof_of_work/cuckaroo_pow.rs
2
69.57
0.0% comms/dht/src/connectivity/mod.rs
1
81.4
-14.76% base_layer/core/src/validation/transaction/transaction_full_validator.rs
1
92.24
1.37% base_layer/transaction_components/src/validation/helpers.rs
1
72.15
-0.42% comms/core/src/connection_manager/listener.rs
1
67.98
-0.49% comms/core/src/connectivity/requester.rs
Jobs
ID Job ID Ran Files Coverage
1 36461308808.1 783
64.02
GitHub Action Run
Source Files on build 36461308808