hyperledger-labs / fabric-smart-client / 36550093923
92%

DEFAULT BRANCH: main
Ran
Jobs 22
Files 503
Run time 2min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 86.72% (+0.2%) from 86.558%
36550093923

push

github

web-flow 
test(fabric): increase coverage of platform/fabric/services/db/driver/sql/common (#1912)

Coverage for the package sat at 50.2% with scripts/filter-coverage.sh
applied. Nearly all of the gap was in vault.go: the existing tests exercise
the store's write paths through sqlmock but never open the lazy vault
reader, so the nine txVaultReader methods and the readers behind them were
uncovered, and the metadata helpers and CreateSchema functions had no tests
at all.

Adds vaultreader_test.go (plain testify, reusing the sqlmock harness from
vaultsql_test.go) covering:

-> the nine txVaultReader methods, both when the lazy open fails and when it
   succeeds and the call delegates
-> buildTxLockVaultReader's isolation-mapper and BeginTx error paths, and
   buildGlobalLockVaultReader holding and releasing the global lock
-> Done on an opened and an unopened reader, and Close
-> convertStateRows' delete, metadata-only and version-mismatch branches,
   plus the sanitizer error paths in convertStateRows, GetStateMetadata and
   queryState
-> GetStateMetadata's no-rows, query-error and bad-metadata paths
-> CreateSchema for the endorse-tx, envelope and metadata stores, and
   GetTableNames including its invalid prefix and parameter cases

marshallMetadata and unmarshalMetadata are unexported, so their round-trip,
empty-input and decode-error tests go in the existing internal vault_test.go.

Package coverage is now 91.0%, measured the same way.

Fixes #1877

Signed-off-by: Siddhi Khandelwal <siddhi.200727@gmail.com>

27897 of 32169 relevant lines covered (86.72%)

2719.3 hits per line

Coverage Regressions

Lines Coverage ∆ File
5
85.04
-1.39% platform/view/services/comm/host/websocket/ws/multiplexed_provider.go
3
45.45
-27.27% platform/view/services/storage/driver/sql/postgres/errormapper.go
2
85.14
-2.7% platform/fabric/core/generic/msp/idemix/cache.go
2
76.83
-0.61% platform/fabric/core/generic/msp/idemix/provider.go
1
89.03
-0.65% platform/view/services/comm/session.go
Jobs
ID Job ID Ran Files Coverage
1 itest-fabric-runtimeconfig - 36550093923.1 459
38.81
GitHub Action Run
2 utest-extensions - 36550093923.2 8
52.57
GitHub Action Run
3 itest-fabric-twonets - 36550093923.3 449
29.21
GitHub Action Run
4 itest-fabricx-iou - 36550093923.4 481
29.2
GitHub Action Run
5 utest-postgres - 36550093923.5 494
9.72
GitHub Action Run
6 itest-fsc-pingpong - 36550093923.6 245
34.61
GitHub Action Run
7 itest-fabricx-configupdate - 36550093923.7 481
28.36
GitHub Action Run
8 itest-fabric-iou - 36550093923.8 459
40.36
GitHub Action Run
9 itest-fabric-stoprestart - 36550093923.9 449
31.21
GitHub Action Run
10 itest-fabric-atsa - 36550093923.10 449
43.6
GitHub Action Run
11 itest-fabric-configupdate - 36550093923.11 459
38.84
GitHub Action Run
12 itest-fabricx-atsa - 36550093923.12 481
30.6
GitHub Action Run
13 itest-fabric-events - 36550093923.13 454
29.01
GitHub Action Run
14 itest-fabricx-deployment - 36550093923.14 481
28.4
GitHub Action Run
15 itest-fabric-iou-libp2p - 36550093923.15 459
36.48
GitHub Action Run
16 itest-fabric-atsachaincode - 36550093923.16 454
30.85
GitHub Action Run
17 itest-fabric-iouhsm - 36550093923.17 459
39.72
GitHub Action Run
18 utest-root - 36550093923.18 494
83.71
GitHub Action Run
19 itest-fabricx-simple - 36550093923.19 481
27.77
GitHub Action Run
20 itest-fsc-signedpingpong - 36550093923.20 240
31.52
GitHub Action Run
21 itest-fabricx-multiendorsement - 36550093923.21 481
28.4
GitHub Action Run
22 itest-fsc-stoprestart - 36550093923.22 241
33.41
GitHub Action Run
Source Files on build 36550093923