akvo / iwsims / #170

89%

push

coveralls-python

[#84] Make mobile form counts match the server, and say when a sync is incomplete (#85)

* [#84] Align mobile form counts with the server list and flag incomplete syncs

Form card counts:
- Count a datapoint as downloaded (locallyCreated = 0) once the server returns
  it in datapoint-list, including unchanged rows, so the card title matches the
  server and rows mislabelled by migration 05 are repaired without a migration
- Card title counts downloaded rows only; Synced now means uploaded but not yet
  listed by the server (awaiting approval)
- Manual Sync requests the full datapoint list; background sync stays incremental
- New read-only GET /device/deleted-datapoints?form_id= returns soft-deleted
  uuids in the assignment scope; the app removes those rows (never drafts or
  unsent changes) before marking the sync complete
- Share the assignment scope filter between datapoint-list and the new endpoint

Incomplete sync banner:
- Show "Download incomplete: X of Y forms. Press Sync to resume." instead of
  "Done" when the sync queue is left behind (app backgrounded or killed,
  failed items, retries exhausted), and whenever the banner is empty
- One finishDatapointSync step (deletions, sync-complete, clear queue) used by
  every path, so a failed final step is retried instead of dropped

Plan: doc/claude/mobile-form-count-server-list.md

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>

* [#84] Keep sync progress from skipping past a failed page

- A page with a failed datapoint download no longer lets a later successful
  page overwrite lastPage, which marked the form complete while the sync was
  flagged as failed: the final step never ran and the banner showed
  "Download not finished" with every form counted as done
- New createPageProgressSaver, shared by SyncService and the background task:
  lastPage stops at the last page before the first failure, so the form sta... (continued)

5835 of 6741 branches covered (86.56%)

Branch coverage included in aggregate %.

10747 of 11964 relevant lines covered (89.83%)

0.9 hits per line