akvo / iwsims

89%

push

coveralls-python

 [#89] Stop pending submissions showing as batches in the Pending Approval tab (#90)

* [#89] Load pending data list in one query instead of one per row

- Fetch created_by, administration, form and parent with select_related
  in PendingFormDataView.get
- Compute has_answer_history with an Exists subquery instead of a
  COUNT query per row in ListPendingFormDataSerializer
- Check form.parent_id so the parent form is not loaded per row
- Reuse the paginator's count instead of running count() twice more
- Add a test that the query count does not grow with the number of rows

A 10-row page went from 41 queries to 1 (2.48s to 0.04s on the test
cluster). The slow response is what let a stale pending-data reply land
in the Pending Approval tab.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>

* [#89] Stop stale pending rows showing in the Pending Approval tab

- Ignore responses for a tab, page, form or filter the user already left,
  using an active flag cleared in the fetch effect's cleanup
- Clear the table and total when the tab or form changes in Submissions
- Apply the same guard to the Control Center PanelSubmissions panel

The slow form-pending-data reply could arrive after the batch reply and
replace it, so pending submissions were drawn with batch columns and
showed "No Approver" with an empty Total Data.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>

* [#89] Address review: serializer fallback and steadier query-count test

- ListPendingFormDataSerializer.get_answer_history falls back to an
  exists() query when the has_answer_history annotation is missing, so
  the serializer is safe to reuse outside PendingFormDataView
- Add a test for the serializer without the annotation
- Assert the 5-row request runs no more queries than the 1-row request
  instead of exactly as many, so a cache warmed by the first request
  can... (continued)

5837 of 6743 branches covered (86.56%)

Branch coverage included in aggregate %.

10749 of 11968 relevant lines covered (89.81%)

0.9 hits per line