JuliaLang / julia / 723

88%

push

buildkite

Filesystem: guard `mv`/`cp` against overlapping paths (#63419)

`mv` and `cp` only compared `src` and `dst` with `samefile`. With
`force=true`, a destination containing the source was removed first,
deleting the source: `mv("pkg/pkg-1.0", "pkg"; force=true)`. A directory
moved or copied into its own subtree was copied into itself until the
path was too long, leaving a tree `rm` could not remove.

Resolve both paths through symlinks, letting the filesystem resolve
`..`, and reject a destination inside a source directory and the forced
removal of a destination containing the source. The check runs once per
copy, and again only below a followed symlink.

Assisted-by: Claude Code (Opus 5.5)
Assisted-by: Codex (gpt-6-astra)

22 of 22 new or added lines in 1 file covered. (100.0%)

91978 of 104336 relevant lines covered (88.16%)

352.02 hits per line