eclipse-aascw / aas-core-codegen / 36536520391

90%

Build Type

push

github

Committed by web-flow

Commit Message

Transpile int and str.lstrip (#792)

We transpile the built-in ``int`` on strings and ``str.lstrip`` for all
the targets so that the meta-model can check the ranges of numeric
strings, *e.g.*, ``xs:long``, instead of relying on implementation-
specific snippets.

The transpiled ``int(text)`` accepts only an optional sign followed by
the ASCII digits, and only the safe integers (``|value| <= 2^53 - 1``),
since TypeScript represents the integers as ``number``. Otherwise, it
throws (panics in Go). The native parsers are not used as they differ
in what they accept (*e.g.*, ``Long.parseLong("٥")`` gives 5). Each
target gets a helper ``ParseSafeInt`` in its common module
(``parse_safe_int`` in Python, ``parseSafeInt`` in Java and
TypeScript), so that both the verification and the understood methods
can call it.

The transpiled ``text.lstrip(chars)`` strips the characters (code
points) as Python does, so 😀 does not strip half of 😁 in UTF-16.

In addition, the Python XML reader of ``xs:long`` now counts
the significant digits before it calls ``int``, as Python refuses more
than 4300 digits, leading zeros included, and the conversion is
quadratic in the length.

The new common meta-model ``int_parsing_and_lstrip`` checks the 64-bit
range of ``xs:long`` without passing an unsafe value to ``int``:

    digits = text.lstrip("+-").lstrip("0")
    ...
    head = int(digits[:10])
    tail = int(digits[10:])

Along the way, we fix large integer literals in Java (``L`` suffix),
and the TypeScript smoke test which assumed that all the verification
functions return a boolean.

Coverage Stats

348 of 354 new or added lines in 40 files covered. (98.31%)

5 existing lines in 5 files now uncovered.

42562 of 48003 relevant lines covered (88.67%)

2.66 hits per line