36523289785
80%

Ran 29 Sep 2026 05:54AM UTC

Jobs 1

Files 66

Run time 1min

Badge

Embed ▾

Committed 28 Sep 2026 03:48PM UTC coverage: 82.737% (-0.07%) from 82.808%

Build # 36523289785

Build Type

push

github

Committed by

web-flow

Commit Message

[FIXED] MQTT: reload stops QoS 1/2 delivery when max_ack_pending is unset (#8671)

Resolves #8661.

A reload that treats the `mqtt` options as changed calls
`mqttUpdateMaxAckPending`, which assigned the configured
`max_ack_pending` to every existing session as is. When the option is
not set that is 0, and `trackPublish` then refuses a packet ID for every
QoS 1/2 message. New sessions were fine because `mqttSessionCreate`
falls back to `mqttDefaultMaxAckPending`; this applies the same fallback
on reload.

The reporter saw it only with `verify_and_map` because a `tls {}` block
makes every reload re-apply the MQTT options. The test covers that no-op
reload and a reload changing `ack_wait` without TLS; both fail without
the fix. `go test ./server -run TestMQTT` passes.

Coverage Stats

72103 of 87147 relevant lines covered (82.74%)

315742.14 hits per line

Coverage Regressions

Lines	Coverage	∆	File
344	88.94	0.03%	src/github.com/nats-io/nats-server/server/mqtt.go
224	89.14	-0.34%	src/github.com/nats-io/nats-server/server/server.go
83	70.16	0.14%	src/github.com/nats-io/nats-server/server/stream_backup.go
40	80.34	-0.54%	src/github.com/nats-io/nats-server/server/raft.go
36	83.14	-0.17%	src/github.com/nats-io/nats-server/server/jetstream_cluster.go
16	73.55	-0.13%	src/github.com/nats-io/nats-server/server/jetstream_api.go
8	87.72	0.15%	src/github.com/nats-io/nats-server/server/consumer.go
7	84.49	-0.35%	src/github.com/nats-io/nats-server/server/jetstream.go
7	77.7	-0.17%	src/github.com/nats-io/nats-server/server/opts.go
7	86.36	-0.05%	src/github.com/nats-io/nats-server/server/stream.go
4	89.56	-0.13%	src/github.com/nats-io/nats-server/server/leafnode.go
3	78.64	-0.02%	src/github.com/nats-io/nats-server/server/filestore.go
2	92.88	-0.02%	src/github.com/nats-io/nats-server/server/client.go
2	85.18	0.05%	src/github.com/nats-io/nats-server/server/events.go
2	55.38	-0.14%	src/github.com/nats-io/nats-server/server/jetstream_errors_generated.go
2	77.36	-1.26%	src/github.com/nats-io/nats-server/server/log.go

Jobs

ID	Job ID	Ran	Files	Coverage
1	36523289785.1	29 Sep 2026 05:54AM UTC	66	82.74	GitHub Action Run

nats-io / nats-server / 36523289785
80%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Coverage Regressions

Jobs

Source Files on build 36523289785

nats-io / nats-server / 36523289785 80%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Coverage Regressions

Jobs

Source Files on build 36523289785

nats-io / nats-server / 36523289785
80%

README BADGES
x