36507708919
72%

Ran 29 Sep 2026 02:18AM UTC

Jobs 1

Files 1102

Run time 2min

Badge

Embed ▾

Committed 28 Sep 2026 03:27PM UTC coverage: 70.358% (-0.01%) from 70.37%

Build # 36507708919

Build Type

push

github

Committed by

web-flow

Commit Message

fix(move-bytecode-verifier): make the cyclic dependency traversal iterative (#13048)

# Description of change

`detect_cycles` in `cyclic_dependencies.rs` walked the module dependency
graph recursively — one nested call per module — so the depth of the
walk was a function of the input graph rather than of anything the pass
controls. `ModuleLoader` in `move-vm-runtime` walks the same graph with
an explicit stack; this pass now matches it.

The recursion is replaced by a loop over a stack of dependency
iterators. Each iterator remembers which sibling comes next at its
level, which is exactly what the call frame was remembering, so the
traversal order is unchanged — the state simply moves from the thread
stack to the heap. Peak allocation is unchanged too: the recursive
version materialised the same `Vec<ModuleId>` per level and held it
across the nested calls.

## Links to any relevant issues

Fixes #13045. 

## How the change has been tested

- [x] Basic tests (linting, compilation, formatting, unit/integration
tests)
- [x] Patch-specific tests (correctness, functionality coverage)
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [x] I have checked that new and existing unit tests pass locally with
my changes

Coverage Stats

184919 of 262825 relevant lines covered (70.36%)

450589.5 hits per line

Coverage Regressions

Lines	Coverage	∆	File
120	0.0	0.0%	crates/iota-indexer/src/store/pg_indexer_analytical_store.rs
94	53.97	0.0%	crates/iota/src/validator_commands.rs
68	0.0	0.0%	crates/iota-indexer/src/apis/indexer_api.rs
62	0.0	0.0%	crates/iota-graphql-rpc/src/types/iota_names_registration.rs
53	33.09	0.0%	crates/iota-indexer/src/models/objects.rs
50	42.94	-1.57%	crates/iota-types/src/dynamic_field.rs
47	94.62	0.03%	crates/starfish/core/src/header_synchronizer.rs
43	94.92	-0.07%	crates/starfish/core/src/commit_syncer/fast.rs
38	0.0	0.0%	crates/iota-indexer/src/processors/move_call_metrics_processor.rs
38	97.7	0.03%	crates/starfish/core/src/shard_reconstructor.rs
37	40.21	0.0%	crates/iota-proxy/src/peers.rs
34	0.0	0.0%	crates/iota-indexer/src/processors/address_metrics_processor.rs
31	68.93	0.0%	crates/iota-json-rpc/src/indexer_api.rs
31	77.25	0.0%	crates/iota-types/src/iota_system_state/mod.rs
31	96.41	0.32%	crates/starfish/core/src/transactions_synchronizer.rs
30	0.0	0.0%	crates/iota-indexer/src/processors/network_metrics_processor.rs
19	0.0	0.0%	crates/iota-types/src/stardust/output/alias.rs
18	95.48	0.33%	crates/starfish/core/src/base_committer.rs
18	80.42	-0.09%	crates/test-cluster/src/lib.rs
15	94.6	0.0%	crates/iota-types/src/iota_system_state/iota_system_state_inner_v1.rs
14	89.43	-5.28%	iota-execution/latest/iota-move-natives/src/authentication_context.rs
13	17.24	0.0%	crates/iota-types/src/stardust/output/nft.rs
13	89.64	-0.05%	crates/starfish/core/src/commit_syncer/regular.rs
12	95.89	-0.28%	crates/starfish/core/src/authority_service.rs
11	39.6	-10.89%	crates/iota-json-rpc-types/src/object_changes.rs
10	67.2	-0.84%	crates/iota-core/src/authority/authority_store.rs
10	89.25	0.81%	crates/iota-test-transaction-builder/src/lib.rs
8	71.74	0.31%	crates/iota-types/src/account_abstraction/authenticator_function.rs
8	91.02	0.54%	crates/iota-types/src/lib.rs
7	72.92	-14.58%	crates/iota-network-stack/src/anemo_ext.rs
7	88.05	0.0%	crates/iota-types/src/dynamic_field/visitor.rs
7	0.0	0.0%	crates/iota-types/src/stardust/output/basic.rs
7	96.84	-0.2%	crates/starfish/core/src/dag_state.rs
7	94.26	0.14%	crates/starfish/core/src/universal_committer.rs
6	89.11	-0.44%	crates/starfish/core/src/network/tonic_network.rs
5	41.67	0.0%	crates/iota-names/src/registry.rs
5	75.18	-0.72%	crates/iota-network/src/randomness/mod.rs
4	56.28	1.52%	crates/iota-json-rpc-types/src/iota_object.rs
4	52.04	1.36%	crates/iota-sdk/src/apis/read.rs
4	82.0	0.0%	crates/iota-vm-sdk/src/executor/types.rs
4	92.47	0.05%	iota-execution/latest/iota-move-natives/src/transfer.rs
3	83.82	-0.58%	crates/iota-core/src/authority_server/validator_v2.rs
3	91.41	-0.13%	crates/iota-core/src/execution_cache/writeback_cache.rs
3	82.14	-2.68%	crates/iota-genesis-builder/src/validator_info.rs
3	21.37	-2.29%	crates/iota-json-rpc-types/src/iota_checkpoint.rs
3	81.53	-0.36%	crates/iota-swarm/src/memory/swarm.rs
3	89.44	0.0%	crates/iota-types/src/iota_system_state/iota_system_state_inner_v2.rs
2	89.0	-0.69%	crates/iota-core/src/connection_monitor.rs
2	92.64	-0.12%	crates/iota-core/src/consensus_adapter.rs
2	93.42	-0.82%	crates/iota-core/src/execution_scheduler/execution_scheduler_impl.rs
2	78.5	-0.42%	crates/iota-core/src/storage.rs
2	82.52	1.05%	crates/iota-sdk/src/wallet_context.rs
2	98.77	-0.09%	crates/iota-types/src/deny_list_v1.rs
1	84.73	-0.49%	crates/iota-core/src/global_state_hasher.rs
1	96.32	0.53%	crates/iota-core/src/transaction_driver/mod.rs
1	76.19	-0.95%	crates/iota-data-ingestion-core/src/reader/fetch.rs
1	89.1	0.0%	crates/iota-network/src/discovery/mod.rs
1	91.04	0.0%	crates/iota-network/src/state_sync/mod.rs
1	92.02	0.0%	crates/starfish/core/src/leader_timeout.rs

Jobs

ID	Job ID	Ran	Files	Coverage
1	nextest+simtest - 36507708919.1	29 Sep 2026 02:18AM UTC	1102	70.36	GitHub Action Run

iotaledger / iota / 36507708919
72%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Coverage Regressions

Jobs

Source Files on build 36507708919

iotaledger / iota / 36507708919 72%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Coverage Regressions

Jobs

Source Files on build 36507708919

iotaledger / iota / 36507708919
72%

README BADGES
x