kobotoolbox / kpi / 36463074933

83%

master: 76%

push

github

fix(frontend): cleanup account fields related code DEV-1850 (#7611)

### 📣 Summary

Fixed the spacing between profile fields in Account Settings on narrow
screens.

### 💭 Notes

Besides a fix this is mainly a refactor. Groundwork for a route blocker.

Changes here:
- `getProfileFieldsValues()` - replaces the hand-written list of 14 keys
in `accountSettingsRoute.tsx`
- `getEditableProfileFieldNames()` - the "hide organization fields from
MMO members" rule; the three field names now live in
`MMO_MANAGED_FIELD_NAMES`
- `areOrganizationFieldsSkipped()` - the `organization_type === 'none'`
skip logic, out of the editor so it can be asked without rendering it
- Unit tests for all three, plus
`envStore.data.getUserMetadataFieldLabel()`
- `isFieldRequired()` was a duplicate of `isRequired()` and is gone

### 👀 Preview steps

1. ℹ️ have an account, go to *Account Settings*
2. narrow the window until the profile fields stack one per row
3. 🔴 [on main] notice one gap twice as tall as the rest, and the social
fields flush together
4. 🟢 [on PR] notice the spacing is even
5. widen the window back
6. 🟢 notice the field pairs still line up as before
7. change a few fields, save, reload
8. 🟢 notice they saved, and only the fields you touched were sent
(`PATCH /me/`)

10449 of 13809 branches covered (75.67%)

33338 of 40126 relevant lines covered (83.08%)

5.51 hits per line