ruby-grape / grape / 36440004561

99%

master: 100%

Build Type

Pull #3014

github

Committed by ericproulx

Commit Message

Validate a blank element of an optional Array block sent with others

An optional Array param given a block passed over every empty element,
even one sent next to real ones, so `[{"sku":"A"}, {}]` passed
`requires :sku` inside the block and `[{"sku":"A"}, null]` reached the
endpoint, where `params[:variants].map { |variant| variant[:sku] }`
raised. HashElementsValidator (#2957) likewise passed over every blank
element that is not a Hash.

The pass-over exists for two things, and both are kept: an optional
scope left out of an element of an Array further up (the iterator hands
its empty value to the validators), and an Array whose elements are all
blank, which ParamsScope#should_validate? passes over as if the param
were left out. An empty element sent with others is neither, and is now
validated like any other.

AttributesIterator now yields, with each value, whether it is an element
the request sent in the scope's own Array. It works that out once per
Array: an optional scope's Array whose elements are all empty is passed
over there, the rule should_validate? applies at the root, so a nested
`[{}, {}]` still passes. Base#validate! passes over an empty value only
when it is not such an element; #validate_elements! passes over only the
placeholder of a left-out scope, and an all-empty Array (reachable
through `oneof`, which runs a variant's validators directly).
HashElementsValidator passes over an Array whose elements are all blank
and otherwise rejects a blank element that is not a Hash.

DefaultValidator does not read the new flag, so where defaults are
filled in is unchanged.

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>

Pull Request Pull Request #3014: Validate a blank element of an optional Array block sent with others

Coverage Stats

1486 of 1505 branches covered (98.74%)

Branch coverage included in aggregate %.

20 of 20 new or added lines in 3 files covered. (100.0%)

36 existing lines in 8 files now uncovered.

4300 of 4337 relevant lines covered (99.15%)

14794.3 hits per line