IJHack / QtPass / 36414207881

68%

main: 93%

Build Type

push

github

Committed by web-flow

Commit Message

1.8: keep the entry when saving it fails (ported from #1951) (#1952)

* 1.8: keep the entry when saving it fails (ported from #1951)

The password dialog closed as soon as OK was pressed and started the
insert on its way out; when gpg then failed (a missing or expired
recipient key, an unusable .gpg-id as in #1944) what was typed was lost.

accept() now inserts and waits, fields, OK, Cancel and Ctrl+T locked,
"Saving…" in the status line:
- finishedInsert closes the dialog as accepted;
- the new Pass::insertFailed(err, written), emitted next to
  processErrorExit for a failed PASS_INSERT, unlocks the fields with the
  entry still in them and shows the reason;
- a refusal through critical() during the Insert() call is handled the
  same way;
- a new entry closes when the backend says it was written and only git
  failed: ImitatePass once its gpg step (which writes the entry itself
  here) succeeded, RealPass when the entry is new since the insert began.
Cancel, Esc and the close button wait for the result.

Not ported: the field-name Enter fix (1.8 has no editable field names),
the name row and template box (2.0 only).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01JuQsrHonihp1nARE7bzstc

* CHANGELOG: 1.8.2's Bugfixes heading is no longer the first

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01JuQsrHonihp1nARE7bzstc

---------

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>

Coverage Stats

49 of 60 new or added lines in 6 files covered. (81.67%)

73 existing lines in 2 files now uncovered.

5122 of 7480 relevant lines covered (68.48%)

93.68 hits per line