IJHack / QtPass / 36411484084

93%

Build Type

push

github

Committed by web-flow

Commit Message

PasswordDialog: keep the entry when saving it fails (#1951)

* PasswordDialog: keep the entry when saving it fails

The dialog closed as soon as OK was pressed and started the insert on its
way out; gpg ran after exec() had returned. When that failed (a missing
or expired recipient key, the empty .gpg-id of #1944, a refused path)
the error was shown and what was typed was gone.

accept() now starts the insert itself and stays open, fields and OK
locked, "Saving…" in the status line, until the backend reports:
- finishedInsert closes the dialog as accepted;
- the new Pass::insertFailed (emitted next to processErrorExit for a
  failed PASS_INSERT, as generateGPGKeysFailed is for key generation)
  unlocks the fields, which still hold the entry, and shows the reason;
- a refusal before anything starts comes through critical() during the
  Insert() call and is handled the same way.
A new entry that is on disk after a failure was written and only a later
git step failed; the dialog then closes and the main window reports git.
An existing entry OK'd before its decrypt arrived now leaves the dialog
open instead of closing without saving.

FieldLabel also consumes Enter: confirming a field rename used to reach
the dialog's default button and save and close the whole entry.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01JuQsrHonihp1nARE7bzstc

* PasswordDialog: wait out a pending save; the backend says what was written

Review follow-ups:
- Cancel, Esc and the window's close button are refused while an insert
  is in flight (reject() override, Cancel disabled): a failure after the
  dialog was gone had nothing left to hand back.
- The template box and Ctrl+T are locked while saving; another template
  would rebuild the field rows under the pending insert.
- "The file is there now" was no proof that this insert wrote it: another
  writer could create the name meanwhile. insertFailed() now carries
  `writ... (continued)

Coverage Stats

72 of 77 new or added lines in 7 files covered. (93.51%)

44 existing lines in 4 files now uncovered.

9065 of 9758 relevant lines covered (92.9%)

191.64 hits per line